Feat: post zhejiang fixes #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-dao into feature/shapella-upgrade-tests-base-oracle
…om:lidofinance/lido-dao into feature/shapella-upgrade-tests-base-oracle
…-methods-update Update batching view methods for StakingRouter
…ounting-oracle-check Refactor: move sanity check out of while loop for optimizing gas usage
handle oracle report edge tests
…nor-comments Feature/post zhejiang fixes nor comments
ujenjt
reviewed
Feb 13, 2023
contracts/0.4.24/Lido.sol
Outdated
| function getStakingFeeAggregateDistributionE4Precision() external view returns (uint16 modulesFee, uint16 treasuryFee); | ||
| } | ||
|
|
||
| interface IWithdrawalQueue { | ||
| function finalizationBatch(uint256 _lastRequestIdToFinalize, uint256 _shareRate) | ||
| function finalizationBatch(uint256 _nextFinalizedRequestId, uint256 _shareRate) |
ujenjt
reviewed
Feb 13, 2023
contracts/0.4.24/Lido.sol
Outdated
|
|
||
| // Step 9. Sanity check for the provided simulated share rate | ||
| if (_reportedData.lastFinalizableRequestId != DONT_FINALIZE_WITHDRAWALS) { | ||
| uint256 noWithdrawalsPostTotalShares = postTotalShares; |
There was a problem hiding this comment.
postTotalSharesIfNoWithdrawalsProcessed - ?
ujenjt
reviewed
Feb 13, 2023
| @@ -363,8 +363,6 @@ contract StETH is IERC20, Pausable { | |||
| function transferSharesFrom( | |||
| address _sender, address _recipient, uint256 _sharesAmount | |||
| ) external returns (uint256) { | |||
| _whenNotStopped(); | |||
…o feature/tests-fix
Fix: share rate sanity check
replace selfdestruct with setBalance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for #482.
The protocol had been deployed on Zhejiang using commit
f4260d168029d580919b4625b6e03e0fa983c27a.